Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REF] minor code cleanup - move indexExist calculation to the only place in the code that needs it #14650

Merged
merged 1 commit into from
Jun 28, 2019
Merged

[REF] minor code cleanup - move indexExist calculation to the only place in the code that needs it #14650

merged 1 commit into from
Jun 28, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Improve code readability on CustomField::create function

Before

indexExists declared a long way from where it is used

After

indexExists declared where it is used (it could also be pushed down into the next function I think in a later round)

Technical Details

Comments

@eileenmcnaughton
[REF] minor code cleanup - move indexExist calculation to the only pl…
9c976bd 
…ace in the code that needs it

Readability fix
@civibot
Copy link

civibot bot commented Jun 27, 2019

(Standard links)

@civibot civibot bot added the master label Jun 27, 2019
@colemanw
Copy link
Member

Looks very sensible.

@colemanw colemanw merged commit 0c00837 into civicrm:master Jun 28, 2019
@colemanw colemanw deleted the cust_field_create branch June 28, 2019 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @colemanw